Numeric ids for runs, jobs and workflows, so gh run and gh workflow work #325
Intentwhat this change is meant to do
Make gh run list/view/watch/rerun/cancel and gh workflow list/view/run work against Diffinery by answering with GitHub's numeric ids and accepting them back, as reported on GitHub #4 and #5.
test-bot merged commit 310c083 into main
Pull request successfully merged and closed
test-bot merged 310c083 into main
Sign in to join the conversation.
Requested by Can · project thread
#What this changes
GitHub issues codician-team/diffinery#4 and #5 reported that
gh run listandgh workflow listcrash withcannot unmarshal string into Go struct field Run.workflow_runs.ID of type int64. gh expects GitHub's numeric ids, and Diffinery answered with hex strings and workflow paths.id, a job'srun_id, a run'sworkflow_idandcheck_suite_id, check suites'id, and therun_idreturned by dispatch and re-run are now numbers.github.run_id,diffinery run view 42).app-<login>-<sha>.html_urlkeeps the hex id, and the web pages accept either form.workflow_run_idandrun_url, as GitHub does withreturn_run_details.job/N_step.txtper step.gh run view --logshows each line under its step instead ofUNKNOWN STEP.#How it was tested
test/unit/rerun.test.tscover the number mapping, lookups, run numbers still working, logs, and artifacts by run number. All 1130 unit tests pass and typecheck is clean.gh run list(also--workflow),gh run view(with--job,--logper step and--jsonwith databaseId and workflowDatabaseId),gh run watch,gh run rerun,gh run cancel,gh workflow list,gh workflow viewandgh workflow run --ref.gh apireads ofcheck-runs/<job id>, check suites by number, and an external app's suite by number.#Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_015ALxdbMU5hpZXjGpL2jhC4