Diffinery runner: job test (Unit tests (1/2)) for codician/diffinery@3125d38aa9f4Runner: image diffinery-runner:0d9b89e0a449e5faecf2b19c, in ams17, WEUR, container 14e30fe0931ee354b6fc52a8d1587c69ee3f81e989b07435d9672e1f49ebe109Runner size: large (4 vCPU, 12 GiB of memory, 20 GB of disk), this job uses what a smaller runner doesn't have; runs-on: diffinery-large (or -medium, -small, -tiny) sets a sizeHost: AMD EPYC (family 25, model 17), 4 vCPUs, 2550 MHzWorkspace: /workspace/diffinery

##[group]Run actions/checkout@v4##[endgroup]Syncing repository: codician/diffineryFetching the repository (depth 1)remote: Enumerating objects: 628, done.        Receiving objects:   0% (1/628)
Receiving objects:   1% (7/628)
Receiving objects:   2% (13/628)
Receiving objects:   3% (19/628)
Receiving objects:   4% (26/628)
Receiving objects:   5% (32/628)
Receiving objects:   6% (38/628)
Receiving objects:   7% (44/628)
Receiving objects:   8% (51/628)
Receiving objects:   9% (57/628)
Receiving objects:  10% (63/628)
Receiving objects:  11% (70/628)
Receiving objects:  12% (76/628)
Receiving objects:  13% (82/628)
Receiving objects:  14% (88/628)
Receiving objects:  15% (95/628)
Receiving objects:  16% (101/628)
Receiving objects:  17% (107/628)
Receiving objects:  18% (114/628)
Receiving objects:  19% (120/628)
Receiving objects:  20% (126/628)
Receiving objects:  21% (132/628)
Receiving objects:  22% (139/628)
Receiving objects:  23% (145/628)
Receiving objects:  24% (151/628)
Receiving objects:  25% (157/628)
Receiving objects:  26% (164/628)
Receiving objects:  27% (170/628)
Receiving objects:  28% (176/628)
Receiving objects:  29% (183/628)
Receiving objects:  30% (189/628)
Receiving objects:  31% (195/628)
Receiving objects:  32% (201/628)
Receiving objects:  33% (208/628)
Receiving objects:  34% (214/628)
Receiving objects:  35% (220/628)
Receiving objects:  36% (227/628)
Receiving objects:  37% (233/628)
Receiving objects:  38% (239/628)
Receiving objects:  39% (245/628)
Receiving objects:  40% (252/628)
Receiving objects:  41% (258/628)
Receiving objects:  42% (264/628)
Receiving objects:  43% (271/628)
Receiving objects:  44% (277/628)
Receiving objects:  45% (283/628)
Receiving objects:  46% (289/628)
Receiving objects:  47% (296/628)
Receiving objects:  48% (302/628)
Receiving objects:  49% (308/628)
Receiving objects:  50% (314/628)
Receiving objects:  51% (321/628)
Receiving objects:  52% (327/628)
Receiving objects:  53% (333/628)
Receiving objects:  54% (340/628)
Receiving objects:  55% (346/628)
Receiving objects:  56% (352/628)
Receiving objects:  57% (358/628)
Receiving objects:  58% (365/628)
Receiving objects:  59% (371/628)
Receiving objects:  60% (377/628)
Receiving objects:  61% (384/628)
Receiving objects:  62% (390/628)
Receiving objects:  63% (396/628)
Receiving objects:  64% (402/628)
Receiving objects:  65% (409/628)
Receiving objects:  66% (415/628)
Receiving objects:  67% (421/628)
Receiving objects:  68% (428/628)
Receiving objects:  69% (434/628)
Receiving objects:  70% (440/628)
Receiving objects:  71% (446/628)
Receiving objects:  72% (453/628)
Receiving objects:  73% (459/628)
Receiving objects:  74% (465/628)
Receiving objects:  75% (471/628)
Receiving objects:  76% (478/628)
Receiving objects:  77% (484/628)
Receiving objects:  78% (490/628)
Receiving objects:  79% (497/628)
Receiving objects:  80% (503/628)
Receiving objects:  81% (509/628)
Receiving objects:  82% (515/628)
Receiving objects:  83% (522/628)
Receiving objects:  84% (528/628)
Receiving objects:  85% (534/628)
Receiving objects:  86% (541/628)
Receiving objects:  87% (547/628)
Receiving objects:  88% (553/628)
Receiving objects:  89% (559/628)
Receiving objects:  90% (566/628)
Receiving objects:  91% (572/628)
Receiving objects:  92% (578/628)
Receiving objects:  93% (585/628)
Receiving objects:  94% (591/628)
Receiving objects:  95% (597/628)
Receiving objects:  96% (603/628)
remote: Total 628 (delta 0), reused 628 (delta 0)        Receiving objects:  97% (610/628)
Receiving objects:  98% (616/628)
Receiving objects:  99% (622/628)
Receiving objects: 100% (628/628)
Receiving objects: 100% (628/628), 2.57 MiB | 16.04 MiB/s, done.From https://diffinery.com/codician/diffinery * [new ref]         3125d38aa9f48e5c2c945eaa6e228be16f0869df -> origin/mainSwitched to a new branch 'main'HEAD is now at 3125d38aa9f48e5c2c945eaa6e228be16f0869df

Download action repository 'pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1'##[group]Run pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1with:  dest: ~/setup-pnpm  run_install: null  cache: false  cache_dependency_path: pnpm-lock.yaml  package_json_file: package.json  standalone: false##[endgroup]##[group]Running self-installer...Progress: resolved 1, reused 0, downloaded 0, added 0Packages: +1+Progress: resolved 1, reused 0, downloaded 1, added 1, donedependencies:+ pnpm 10.28.0 (12.14.0 is available)Done in 1.1s##[endgroup]Installation Completed!

##[group]Run actions/setup-node@v4with:  node-version: 22  cache: pnpm##[endgroup]Found in cache @ 22.22.0 (pre-installed node satisfies '22')Cache Size: ~216 MB (226515969 B)Cache restored from key: node-cache-Linux-x64-pnpm-aa519d0d5d7e5a224fb440987e5331e1cb7b3a95e67805db372d6def9572f2b0

##[group]Run pnpm install --frozen-lockfile##[endgroup]Scope: all 7 workspace projectsLockfile is up to date, resolution step is skippedProgress: resolved 1, reused 0, downloaded 0, added 0Packages: +249++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++Progress: resolved 249, reused 243, downloaded 0, added 249, donedevDependencies:+ turbo 2.11.7+ typescript 5.9.3Done in 12.9s using pnpm v10.28.0

##[group]Run pnpm -r --if-present build##[endgroup]Scope: 6 of 7 workspace projectsapps/cli build$ esbuild src/bin.ts --bundle --platform=node --target=node22 --format=esm --outfile=dist/diffinery.mjs "--banner:js=#!/usr/bin/env nodeimport { createRequire as __diffineryCreateRequire } from 'node:module'; const require = __diffineryCreateRequire(import.meta.url);"containers/runner build$ esbuild src/main.ts --bundle --platform=node --target=node22 --format=esm --outfile=dist/agent.mjs --external:bufferutil --external:utf-8-validate "--banner:js=import { createRequire as __diffineryCreateRequire } from 'node:module'; const require = __diffineryCreateRequire(import.meta.url);"apps/diffinery build$ node islands/build.mjs && node scripts/build-docs.mjsapps/cli build:   dist/diffinery.mjs  445.1kbapps/cli build: ⚡ Done in 64msapps/cli build: Donecontainers/runner build:   dist/agent.mjs  666.9kbcontainers/runner build: ⚡ Done in 79mscontainers/runner build: Doneapps/diffinery build: islands: kumo.js 466 KB, kumo.css 149 KB, terminal.js 286 KBapps/diffinery build: docs: 65 pages (+2 generated at runtime), CLI 0.1.0 (234 KiB)apps/diffinery build: Done

##[group]Run pnpm -r --if-present run test --shard=1/2##[endgroup]Scope: 6 of 7 workspace projectspackages/git-core test$ vitest run --shard=1/2packages/workflow-yaml test$ vitest run --shard=1/2packages/git-core test: (!) Your Vite config uses features that are unsupported by `configLoader: 'native'`, which is planned to become the default in a future major version of Vite:packages/git-core test:   - import "../../vitest.shared" without a file extension (vitest.config.ts:2:26). Add the file extensionpackages/git-core test:   - ESM syntax in a file loaded as CommonJS (../../vitest.shared.ts:10:1). Use a `.mjs` extension or set `"type": "module"` in the closest package.jsonpackages/git-core test: Set `VITE_CONFIG_NATIVE_IGNORE_WARNING=true` to suppress this warning.packages/git-core test:  RUN  v4.1.11 /workspace/diffinery/packages/git-corepackages/workflow-yaml test: (!) Your Vite config uses features that are unsupported by `configLoader: 'native'`, which is planned to become the default in a future major version of Vite:packages/workflow-yaml test:   - import "../../vitest.shared" without a file extension (vitest.config.ts:2:26). Add the file extensionpackages/workflow-yaml test:   - ESM syntax in a file loaded as CommonJS (../../vitest.shared.ts:10:1). Use a `.mjs` extension or set `"type": "module"` in the closest package.jsonpackages/workflow-yaml test: Set `VITE_CONFIG_NATIVE_IGNORE_WARNING=true` to suppress this warning.packages/workflow-yaml test:  RUN  v4.1.11 /workspace/diffinery/packages/workflow-yamlpackages/workflow-yaml test:  ✓ test/cron.test.ts (23 tests) 30mspackages/git-core test:  ✓ test/pack-stream.test.ts (3 tests) 265mspackages/workflow-yaml test:  ✓ test/expr.test.ts (48 tests) 63mspackages/workflow-yaml test:  ✓ test/parse.test.ts (31 tests) 114mspackages/workflow-yaml test:  Test Files  3 passed (3)packages/workflow-yaml test:       Tests  102 passed (102)packages/workflow-yaml test:    Start at  14:57:01packages/workflow-yaml test:    Duration  789ms (transform 558ms, setup 0ms, import 1.15s, tests 207ms, environment 0ms)packages/workflow-yaml test: Donepackages/git-core test:  ✓ test/diff-budget.test.ts (5 tests) 770mspackages/git-core test:      ✓ a three-way merge too large to compute is a conflict, quickly  480mspackages/git-core test:  ✓ test/pack-limits.test.ts (6 tests) 7430mspackages/git-core test:      ✓ resolves a long delta chain in one pass, whatever order the pack lists it in  3917mspackages/git-core test:      ✓ counts what each object costs in memory, not only its content  1570mspackages/git-core test:      ✓ refuses a small pack whose objects inflate past the memory budget  1897mspackages/git-core test:  Test Files  3 passed (3)packages/git-core test:       Tests  14 passed (14)packages/git-core test:    Start at  14:57:01packages/git-core test:    Duration  8.00s (transform 608ms, setup 0ms, import 981ms, tests 8.47s, environment 0ms)packages/git-core test: Doneapps/cli test$ vitest run --shard=1/2apps/diffinery test$ vitest run --passWithNoTests --exclude 'test/e2e/**' --shard=1/2containers/runner test$ vitest run --shard=1/2containers/runner test: (!) Your Vite config uses features that are unsupported by `configLoader: 'native'`, which is planned to become the default in a future major version of Vite:containers/runner test:   - import "../../vitest.shared" without a file extension (vitest.config.ts:2:26). Add the file extensioncontainers/runner test:   - ESM syntax in a file loaded as CommonJS (../../vitest.shared.ts:10:1). Use a `.mjs` extension or set `"type": "module"` in the closest package.jsoncontainers/runner test: Set `VITE_CONFIG_NATIVE_IGNORE_WARNING=true` to suppress this warning.apps/cli test: (!) Your Vite config uses features that are unsupported by `configLoader: 'native'`, which is planned to become the default in a future major version of Vite:apps/cli test:   - import "../../vitest.shared" without a file extension (vitest.config.ts:2:26). Add the file extensionapps/cli test:   - ESM syntax in a file loaded as CommonJS (../../vitest.shared.ts:10:1). Use a `.mjs` extension or set `"type": "module"` in the closest package.jsonapps/cli test: Set `VITE_CONFIG_NATIVE_IGNORE_WARNING=true` to suppress this warning.apps/diffinery test: (!) Your Vite config uses features that are unsupported by `configLoader: 'native'`, which is planned to become the default in a future major version of Vite:apps/diffinery test:   - import "../../vitest.shared" without a file extension (vitest.config.ts:3:26). Add the file extensionapps/diffinery test:   - ESM syntax in a file loaded as CommonJS (../../vitest.shared.ts:10:1). Use a `.mjs` extension or set `"type": "module"` in the closest package.jsonapps/diffinery test: Set `VITE_CONFIG_NATIVE_IGNORE_WARNING=true` to suppress this warning.containers/runner test:  RUN  v4.1.11 /workspace/diffinery/containers/runnerapps/diffinery test:  RUN  v4.1.11 /workspace/diffinery/apps/diffineryapps/cli test:  RUN  v4.1.11 /workspace/diffinery/apps/cliapps/diffinery test: (node:410) ExperimentalWarning: SQLite is an experimental feature and might change at any timeapps/diffinery test: (Use `node --trace-warnings ...` to show where the warning was created)apps/diffinery test: (node:413) ExperimentalWarning: SQLite is an experimental feature and might change at any timeapps/diffinery test: (Use `node --trace-warnings ...` to show where the warning was created)containers/runner test:  ✓ test/jail.test.ts (12 tests) 223msapps/diffinery test:  ✓ test/unit/usage.test.ts (23 tests) 100msapps/cli test:  ✓ test/login.test.ts (12 tests) 500mscontainers/runner test:  ✓ test/relay.test.ts (4 tests) 1082mscontainers/runner test:      ✓ splits a single-PUT upload (containerd) into PATCH chunks under the limit  347mscontainers/runner test:      ✓ answers a streamed PATCH (docker) like the registry would, then completes with an empty PUT  637msapps/diffinery test: (node:469) ExperimentalWarning: SQLite is an experimental feature and might change at any timeapps/diffinery test: (Use `node --trace-warnings ...` to show where the warning was created)apps/cli test:  ✓ test/pr.test.ts (19 tests) 1290msapps/cli test:      ✓ pr checks --watch waits for the first check right after a push, and gives up after 2 minutes  414msapps/diffinery test: stderr | test/unit/suppression.test.ts > Email Sending's answer to a send > puts a refused recipient on the list (source send) and audits it; temporary failures change nothingapps/diffinery test: email failed test Ann@Example.com E_RECIPIENT_SUPPRESSED: recipient is suppressedapps/diffinery test: stderr | test/unit/suppression.test.ts > Email Sending's answer to a send > puts a refused recipient on the list (source send) and audits it; temporary failures change nothingapps/diffinery test: email failed test bob@example.com E_DAILY_LIMIT_EXCEEDED: nopeapps/diffinery test:  ✓ test/unit/suppression.test.ts (11 tests) 378msapps/cli test:  ✓ test/migrate.test.ts (4 tests) 1560msapps/cli test:      ✓ creates the repo, pushes branches and tags, and copies issues, PRs, variables and secret names  574msapps/cli test:      ✓ repo clone authenticates for that command only  498msapps/cli test:      ✓ --private and --to override the target  347msapps/cli test:  ✓ test/misc.test.ts (9 tests) 367msapps/cli test:  Test Files  4 passed (4)apps/cli test:       Tests  44 passed (44)apps/cli test:    Start at  14:57:09apps/cli test:    Duration  2.96s (transform 1.41s, setup 0ms, import 3.11s, tests 3.72s, environment 9ms)apps/cli test: Donecontainers/runner test:  ✓ test/runtime.test.ts (11 tests) 1361mscontainers/runner test:      ✓ uploads large files as blocks, small ones in one request, and downloads them back  1070msapps/diffinery test: (node:905) ExperimentalWarning: SQLite is an experimental feature and might change at any timeapps/diffinery test: (Use `node --trace-warnings ...` to show where the warning was created)apps/diffinery test:  ✓ test/unit/runner-sizes.test.ts (19 tests) 456msapps/diffinery test: stderr | test/unit/moderation.test.ts > suspension > refuses tokens and sessions at once, stops Actions, and unsuspending restores the tokensapps/diffinery test: mail queue not bound; dropping 1 email(s)apps/diffinery test: stderr | test/unit/moderation.test.ts > suspension > refuses tokens and sessions at once, stops Actions, and unsuspending restores the tokensapps/diffinery test: mail queue not bound; dropping 1 email(s)apps/diffinery test:  ✓ test/unit/moderation.test.ts (9 tests) 171msapps/diffinery test: (node:1068) ExperimentalWarning: SQLite is an experimental feature and might change at any timeapps/diffinery test: (Use `node --trace-warnings ...` to show where the warning was created)apps/diffinery test:  ✓ test/unit/review.test.ts (19 tests) 43msapps/diffinery test:  ✓ test/unit/job-permissions.test.ts (8 tests) 30msapps/diffinery test:  ✓ test/unit/rerun.test.ts (10 tests) 1184msapps/diffinery test:      ✓ treats the call's jobs like any other and re-runs what needs the call  349msapps/diffinery test:  ✓ test/unit/auto-merge.test.ts (12 tests) 360msapps/diffinery test: (node:1228) ExperimentalWarning: SQLite is an experimental feature and might change at any timeapps/diffinery test: (Use `node --trace-warnings ...` to show where the warning was created)apps/diffinery test: stderr | test/unit/rate-limit.test.ts > rate limit checks > lets requests through when no limiter is configured or the limiter failsapps/diffinery test: rate limiter failed RL_ANON Error: downapps/diffinery test:     at Object.limit (/workspace/diffinery/apps/diffinery/test/unit/rate-limit.test.ts:89:67)apps/diffinery test:     at overLimit (/workspace/diffinery/apps/diffinery/src/lib/rate-limit.ts:71:22)apps/diffinery test:     at /workspace/diffinery/apps/diffinery/test/unit/rate-limit.test.ts:90:18apps/diffinery test:     at process.processTicksAndRejections (node:internal/process/task_queues:105:5)apps/diffinery test: stderr | test/unit/killswitch.test.ts > kill switches > counts repositories that couldn't be stopped, and needs a reasonapps/diffinery test: kill switch: stopping work in repository broken failed Error: goneapps/diffinery test:     at Object.stopActions (/workspace/diffinery/apps/diffinery/test/unit/killswitch.test.ts:24:36)apps/diffinery test:     at worker (/workspace/diffinery/apps/diffinery/src/lib/killswitch.ts:155:63)apps/diffinery test:     at Function.from (<anonymous>)apps/diffinery test:     at stopIn (/workspace/diffinery/apps/diffinery/src/lib/killswitch.ts:166:27)apps/diffinery test:     at changePause (/workspace/diffinery/apps/diffinery/src/lib/killswitch.ts:225:21)apps/diffinery test:     at process.processTicksAndRejections (node:internal/process/task_queues:105:5)apps/diffinery test:     at /workspace/diffinery/apps/diffinery/test/unit/killswitch.test.ts:123:12apps/diffinery test:     at async file:///workspace/diffinery/node_modules/.pnpm/@vitest+runner@4.1.11/node_modules/@vitest/runner/dist/chunk-artifact.js:1903:20apps/diffinery test:  ✓ test/unit/killswitch.test.ts (5 tests) 131msapps/diffinery test:  ✓ test/unit/today.test.ts (10 tests) 21msapps/diffinery test:  ✓ test/unit/coordinator.test.ts (8 tests) 20mscontainers/runner test:  ✓ test/import.test.ts (7 tests) 4694mscontainers/runner test:      ✓ pushes history in chunks under a size limit the server enforces, then every ref, and cleans up  2937mscontainers/runner test:      ✓ pushes every version of a large file first and whole, so the server never rebuilds one from a delta  1174mscontainers/runner test:      ✓ splits a refused batch of a large commit's files again, rather than retrying it whole  557msapps/diffinery test:  ✓ test/unit/secret-scan.test.ts (7 tests) 992msapps/diffinery test:      ✓ scans a large file in slices, never as one string, with the same results  772msapps/diffinery test:  ✓ test/unit/job-graph.test.ts (12 tests) 22msapps/diffinery test:  ✓ test/unit/project.test.ts (12 tests) 11msapps/diffinery test: (node:1859) ExperimentalWarning: SQLite is an experimental feature and might change at any timeapps/diffinery test: (Use `node --trace-warnings ...` to show where the warning was created)apps/diffinery test: stderr | test/unit/rate-limit.test.ts > model requests per paying person (phase 5a) > counts per person, and lets requests through without a binding or when it failsapps/diffinery test: model rate limiter failed Error: downapps/diffinery test:     at Object.limit (/workspace/diffinery/apps/diffinery/test/unit/rate-limit.test.ts:130:61)apps/diffinery test:     at modelRateLimited (/workspace/diffinery/apps/diffinery/src/lib/rate-limit.ts:90:33)apps/diffinery test:     at /workspace/diffinery/apps/diffinery/test/unit/rate-limit.test.ts:131:18apps/diffinery test:     at process.processTicksAndRejections (node:internal/process/task_queues:105:5)apps/diffinery test:     at async file:///workspace/diffinery/node_modules/.pnpm/@vitest+runner@4.1.11/node_modules/@vitest/runner/dist/chunk-artifact.js:1903:20apps/diffinery test:  ✓ test/unit/rate-limit.test.ts (10 tests) 3495msapps/diffinery test:      ✓ answers 429 with retry-after once an anonymous address is over its limit  3465msapps/diffinery test:  ✓ test/unit/job-token.test.ts (7 tests) 111msapps/diffinery test:  ✓ test/unit/markdown-safety.test.ts (28 tests) 402msapps/diffinery test: (node:1871) ExperimentalWarning: SQLite is an experimental feature and might change at any timeapps/diffinery test: (Use `node --trace-warnings ...` to show where the warning was created)apps/diffinery test:  ✓ test/unit/reusable.test.ts (4 tests) 24msapps/diffinery test:  ✓ test/unit/visibility.test.ts (3 tests) 85msapps/diffinery test:  ✓ test/unit/deploy-log-notes.test.ts (2 tests) 52msapps/diffinery test:  ✓ test/unit/required.test.ts (11 tests) 10msapps/diffinery test:  ✓ test/unit/redirects.test.ts (9 tests) 9msapps/diffinery test:  ✓ test/unit/fsck.test.ts (16 tests) 501msapps/diffinery test:      ✓ refuses a tree too large to check, before reading its names  481msapps/diffinery test:  ✓ test/unit/registry-upload.test.ts (2 tests) 637msapps/diffinery test:      ✓ hash each chunk as it arrives, so the final request doesn't read the blob back  562msapps/diffinery test:  ✓ test/unit/push-retry.test.ts (4 tests) 7msapps/diffinery test:  ✓ test/unit/org-variables.test.ts (2 tests) 10msapps/diffinery test:  ✓ test/unit/wait-timer.test.ts (5 tests) 6msapps/diffinery test:  ✓ test/unit/stages.test.ts (3 tests) 8msapps/diffinery test:  ✓ test/unit/d1.test.ts (3 tests) 10msapps/diffinery test:  ✓ test/unit/environment-secrets.test.ts (4 tests) 10msapps/diffinery test:  ✓ test/unit/receive-head.test.ts (2 tests) 21msapps/diffinery test:  ✓ test/unit/upload-pack.test.ts (1 test) 991msapps/diffinery test:      ✓ sends each object as it is read, in side-band packets, never the whole pack at once  989msapps/diffinery test:  ✓ test/unit/job-secrets.test.ts (4 tests) 10msapps/diffinery test:  ✓ test/unit/tree-names.test.ts (5 tests) 11msapps/diffinery test: (node:2186) ExperimentalWarning: SQLite is an experimental feature and might change at any timeapps/diffinery test: (Use `node --trace-warnings ...` to show where the warning was created)apps/diffinery test:  ✓ test/unit/inflight.test.ts (1 test) 36msapps/diffinery test:  ✓ test/unit/archive-stream.test.ts (3 tests) 510msapps/diffinery test:      ✓ refuse more entries than classic zip can hold instead of writing a broken archive  381msapps/diffinery test:  ✓ test/unit/terminal-command.test.ts (1 test) 9msapps/diffinery test:  ✓ test/unit/unpack-failure.test.ts (2 tests) 6msapps/diffinery test:  ✓ test/unit/graphql.test.ts (3 tests) 10msapps/diffinery test:  Test Files  39 passed (39)apps/diffinery test:       Tests  300 passed (300)apps/diffinery test:    Start at  14:57:09apps/diffinery test:    Duration  12.19s (transform 9.27s, setup 0ms, import 14.71s, tests 10.90s, environment 6ms)apps/diffinery test: Done